twbs/bootstrap

Tab plugin should use a class selector instead of a ul tag selector

Closed this issue · 4 comments

Invis1ble commented

Hello. I want to use <ol> instead of <ul>, but in the Tab plugin tag name is hardcoded.
https://github.com/twbs/bootstrap/blob/master/js/tab.js#L28

var $ul      = $this.closest('ul:not(.dropdown-menu)')
cvrebert commented

I want to use <ol> instead of <ul>

Why?

Invis1ble commented

Because I have an ordered list.

cvrebert commented

Because I have an ordered list.

And you have an ordered list because...?

Invis1ble commented

And you have an ordered list because...?

Because it is an ordered dataset from database and it should be displayed as an orderd list of tabs. It is semantic, isn't it?