`selector-class-pattern` change in >= v3.0.0-alpha1

Question

`selector-class-pattern` change in >= v3.0.0-alpha1

danny007in opened this issue 3 years ago · 6 comments

Expected keyframe name to be kebab-case keyframes-name-pattern

@keyframes flipInX {

Expected class selector to be kebab-case selector-class-pattern

.svg-inline--fa,

Answer 1 · 2021-12-11T19:19:00.000Z

That intended. Feel free to disable the rule on your project.

Answer 2 · 2021-12-11T19:22:22.000Z

Actually, let's keep the issue open. I will rethink about it, but keep in mind this is a major version.

Either way the change was intentional, but if if people prefer the old way I guess we could revisit this change.

Answer 3 · 2021-12-14T07:32:28.000Z

@ffoodd do you think we should revert the selector-class-pattern change to our custom rule which was less restrictive? Now, it's strictly kebab case.

Answer 4 · 2021-12-14T20:14:30.000Z

I'd be in favor of keeping it, as we only use kebab-case. Linter rules are meant to reinforce our coding conventions, so it totally makes sense this way.

Answer 5 · 2021-12-14T20:22:54.000Z

All right, I agree, but do note that we too had to override this in one case in our docs.

I'll release v3.0.0 tomorrow :)

Answer 6 · 2021-12-15T09:14:31.000Z

Closing since we are going to stick with the new behavior for the time being.