twelvesec/roben

String vs Boolean

TerminalFi opened this issue · 3 comments

TerminalFi commented

Why is a string being used here instead of passing a boolean value?

roben/roben.py

Line 62 in ebc8840

flag = "FALSE"

nickvourd commented

It is python, no matters Boolean or strings

TerminalFi commented

I mean, they are different for a reason. Sure you can still test against a string but why not just test such as the following. I just don't see why you use strings like that.

if flag:
    pass

if not flag:
    pass
nickvourd commented

We will fix it ASAP, however this piece of code doesn't troubleshooting the functionality of the main program!