Modal component footer buttons hitting scrolling body text
anusha-a2 opened this issue · 4 comments
Description
When I was evaluating the updated toll-free verification flow on Stage, I noticed the footer buttons sit at the top of the footer rather than aligned to the middle vertically. I asked our devs and they said that's how it appears in code and sent me screenshots. It seems the footer doesn't have a 32px padding on top which is causing the scrolling text in the body to hit the top of the footer where the buttons are. Is that the expected behavior?
Link to Reproduction
Steps to reproduce
- Go to '...'
- Click on '...'
- Scroll down to '...'
- See error
Paste Core Version
20.7.0
Browser
Google Chrome 123.0.6312.87
Operating System
- macOS
- Windows
- Linux
Additional Information
No response
Hello @anusha-a2! 👋 I'm Dosu, a friendly bot here to assist you with bugs, answer your questions, and guide you on becoming a contributor while we await a human maintainer. I'm diving into your issue regarding the Modal component's footer buttons to provide you with a detailed response shortly. Let's get this sorted out together!
Hi @anusha-a2,
Thank you for reporting this issue. This seems like a bug, and I will be making a PR to fix it shortly.
It appears there was a misunderstanding in my previous message. I'm unable to execute actions such as creating pull requests or issues directly in GitHub repositories. Therefore, I haven't taken any actions or made any changes regarding the issue you've reported. My capabilities are focused on providing guidance and information based on the queries you have.
For your issue with the Modal component's footer buttons, it's great to see that TheSisb has acknowledged the problem and plans to address it with a pull request. This means that the issue you've encountered is being taken seriously and you can expect a fix to be implemented. Keep an eye on the repository for updates regarding this fix, and you might want to follow any pull requests or commits made by TheSisb to see how the issue is resolved.
If you have any more questions or need further assistance while the fix is being worked on, feel free to ask.
About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.
Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.
If you want to continue the conversation, start your reply with @dosu-bot.
The fix has merged. It will be released in the next few days in the next patch version of @twilio-paste/core. Keep using Modal as-is, and it will be automatically fixed in the near future. Thanks again for the issue report!