twilio/twilio-video-app-ios

Error view visibility when we have video track nil

Closed this issue · 1 comments

Before Creating an Issue

Description

we try to disable video , it doesn't show error view when video track is nil or video is disable.

Steps to Reproduce

  1. perform toggleVideoPressed in LobbyViewController
  2. Disabling video camera makes video track nil but it doesn't show Error View when video track is nil

Expected Behaviour

  1. I believe we should have error view visible when we don't have video track.

Versions

  • Video app version: 4.1.0
  • iOS version: 14.6
  • Device: iPhone 7
  • Xcode version: 12.4

Log

// Log output when the issue occurs

Suggestion can be

  • I believe we can update below lines inside VideoView.swift

From
errorView.isHidden = !(config.videoTrack?.isSwitchedOff ?? false)

To
errorView.isHidden = !(config.videoTrack?.isSwitchedOff ?? true)

Thanks for your time :)

Thanks for the feedback @MayurTanna1. As discussed in this PR I think the functionality is by design. Please see the PR for more details. Thanks!