Error view visibility when we have video track nil
Closed this issue · 1 comments
MayurTanna1 commented
Before Creating an Issue
- If there is an issue specific to the video app report it here. If there is an issue or question related to the video SDK please create an SDK issue instead.
- Make sure the issue is not already addressed by docs or existing issues.
- Please do not share any
Personally Identifiable Information or sensitive information like API keys when creating an issue.
Description
we try to disable video , it doesn't show error view when video track is nil or video is disable.
Steps to Reproduce
- perform toggleVideoPressed in LobbyViewController
- Disabling video camera makes video track nil but it doesn't show Error View when video track is nil
Expected Behaviour
- I believe we should have error view visible when we don't have video track.
Versions
- Video app version: 4.1.0
- iOS version: 14.6
- Device: iPhone 7
- Xcode version: 12.4
Log
// Log output when the issue occurs
Suggestion can be
- I believe we can update below lines inside VideoView.swift
From
errorView.isHidden = !(config.videoTrack?.isSwitchedOff ?? false)
To
errorView.isHidden = !(config.videoTrack?.isSwitchedOff ?? true)
Thanks for your time :)
timrozum commented
Thanks for the feedback @MayurTanna1. As discussed in this PR I think the functionality is by design. Please see the PR for more details. Thanks!