URLs with IP address as host aren't valid

Question

URLs with IP address as host aren't valid

Opened this issue 9 years ago · 5 comments

[7] pry(main)> Twingly::URL.parse("http://127.0.0.1:57029").valid?
=> false

I think they should be valid, they are perfectly valid URLs and I think we want to use URLs like that when we test in our projects... and if the project use twingly-url, it will reject our valid test URLs :-(

They are not valid because of our PublicSuffix demands:

[11] pry(main)> PublicSuffix.parse("http://127.0.0.1:57029")
PublicSuffix::DomainInvalid: `http://127.0.0.1:57029' is not a valid domain
from /Users/dentarg/.gem/ruby/2.2.3/gems/public_suffix-1.5.3/lib/public_suffix.rb:62:in `parse'

Answer 1 · 2016-01-20T13:56:52.000Z

Somewhat related to #52 (and possibly others)

Answer 2 · 2016-09-14T14:46:31.000Z

In #90 we learned how to extend the PSL, I guess it should be possible to write a PublicSuffix rule that allow IP addresses. :-)

Answer 3 · 2017-06-22T13:31:42.000Z

Or, if we identify the input as an IP address, we could skip the PSL step in that case.

Answer 4 · 2017-06-22T13:34:57.000Z

IPAddr could probably be used.

Answer 5 · 2018-06-10T08:50:48.000Z

https://github.com/knu/ruby-domain_name

host = DomainName("[::1]")  # IP addresses like "192.168.1.1" and "::1" are also acceptable
host.ipaddr?        #=> true