twitter/twemoji

the svg folder is in a merge pull, but png is still missing in the latest version v12.0.4

Closed this issue · 7 comments

hello,
it is missing the svg assets totally!!!

image

it used to be in node_modules/twemoji/2/svg/ ... but missing! as well as .png folder!

duplicate of #356

but the referenced issue was closed without resolution. how come ?

i see there is a fix merge pull that added in svg, but png is missing

As far as I can tell, we never intended to ship image assets in the npm package. They bloat the download for most people who'll end up referencing them via MaxCDN. @bhaggs and I have talked a bit about shipping assets separately, but for now I'd recommend pulling them from github.

useless package in npm without assets. so funny

useless package in npm without assets. so funny

@p3x-robot the base url points at MaxCDN as you can see in this part of the code:
https://github.com/twitter/twemoji/blob/gh-pages/2/twemoji.js#L26-L27

that means at least two things:

  • the package works out of the box for online use cases
  • you can change that base url to point at any other local/online resource

This project aim was since the beginning to provide a best in class helper to parse live nodes or strings, shipping assets has been introduced way after and indeed made the installation via npm instantly slower and heavier everywhere.

I believe creating a twemoji-assets package a part is indeed a very good idea, but I hope people won't call this project useless in the future.