twitter/util

Minor - Wrong Code in Cookbook documentation

madhava-sridhar opened this issue · 3 comments

Wrong Code in Cookbook documentation

Expected behavior

In page https://twitter.github.io/util/guide/util-cookbook/futures.html , in 1st Code example method "asScala" has param "implicit e: ExecutionContext " which is not required by code contained in the method "asScala" (Execution Context is not used by contained code as well)

Actual behavior

method "asScala" doesn't have param "implicit e: ExecutionContext "

Steps to reproduce the behavior

NA

yep, good eyes.

any interest in putting together the small PR to fix?

Hi, I'd like to take a go at this!

Fixed by #247.