Device list images look odd if many are missing

Question

Device list images look odd if many are missing

Closed this issue 5 years ago · 5 comments

@stefanomondino posted a screenshot of the app running on his Mac, and it seems to be missing almost all the device pictures. If two or three were missing I'd say it's OK, but here many are missing and all the question marks looks strange to me.

Answer 1 · 2020-02-13T15:18:44.000Z

@stefanomondino I have a theory... If I push up a branch would you be willing to try it out and see if it solves this?

Answer 2 · 2020-02-13T15:23:21.000Z

@davedelong sure!

Answer 3 · 2020-02-13T16:00:23.000Z

Just in case another data point is needed: I see the same thing on my box, only the "Default" entry has an image, all the others show question marks. Let me know if/when I can help debug.

Answer 4 · 2020-02-13T16:24:41.000Z

I just reproduced this on my laptop. Investigating...

Answer 5 · 2020-02-13T16:45:35.000Z

OK, I think this related to #11 . The returned JSON doesn't have the device type identifier, so it's falling back to public.device. public.device doesn't have an icon, so it's default to the question mark icon (#9).