twuni/docker-registry.helm

config path will change with distribution 3

mawatech opened this issue · 2 comments

With the next release the config path will change from /etc/docker/registry/config.yml to /etc/distribution/config.yml

See distribution/distribution#4365

Perhaps it make sense to make the mount path configurable?

Thanks for bringing this up, @mawatech!

That will definitely be a breaking change, since that mount path is hard-coded right now.

Are there other breaking changes to consider in v3?

This seems like a two-part fix:

  1. Update the current version of the chart to support an override to the configuration path (i.e: introduce a new configuration value and wire that into the volumeMounts helper), using a default equal to the currently hard-coded value so there are no functional changes for existing users of this chart.
  2. When v3 is officially released, update the default image.tag and config path value (+ any other necessary adjustments). Whether that's a major version increment for this chart as well, I defer for discussion.
  1. When v3 is officially released, update the default image.tag and config path value (+ any other necessary adjustments). Whether that's a major version increment for this chart as well, I defer for discussion.

I would argue for a major chart version increment for two reasons - the underlying image is a major change, and as well we are introducing breaking changes to the chart