Missing #[builder(default)] on builder impls

Question

Missing #[builder(default)] on builder impls

tychedelia opened this issue a year ago · 2 comments

See colin-kiegel/rust-derive-builder#261.

Answer 1 · 2023-09-16T12:25:19.000Z

Ooooh, does this fix the issue where literally every field of the builder needs to be set? I didn't think to report it as an issue but did think it was a strange design 😅

Answer 2 · 2023-09-16T23:07:50.000Z

Ooooh, does this fix the issue where literally every field of the builder needs to be set? I didn't think to report it as an issue but did think it was a strange design 😅

Yes! I thought this was just a design oversight too, but dug deeper. Seems a bit strange this isn't the default behavior, as I can't imagine a situation where you wouldn't want to fall back to default. In general, I find the builders much more ergonomic then changing a bunch of mutable fields, particularly after we decided to make all the messages non-exhaustive.