Change plugin prefix to not conflict with Bugbear
ambv opened this issue · 3 comments
Bugbear is an official PyCQA plugin for flake8 that's been around for several years.
Your new plugin shadows the letter B and in fact deregisters Bugbear if used in the same configuration.
Please choose a new non-conflicting prefix for your plugin.
For reference, see: PyCQA/flake8-bugbear#37
@tylerwince @ambv I've made a further comment at PyCQA/flake8-bugbear#37. I'm quoting the salient points below:
The conflict is not with
flake8-bandit
but rather withopenstack/bandit
There are two projects that are involved here:
https://github.com/openstack/bandit
- Project started on 16 July 2014
- This is the main project, where the conflicts are arising
https://github.com/tylerwince/flake8-bandit
- Project started on 29 Oct 2017
- However, this is just a wrapper around
bandit
- They have no control over the error codes that are supplied by
bandit
The OpenStack Bandit project has been using
B30x
codes for a few years as wellTaking
B301
as the earliest example in both projects:
Bandit: openstack-archive/bandit@c364408
- This commit was made on 22 Jan 2016
Bugbear: PyCQA/flake8-bugbear@0fb7d8d
- This commit was made on 8 Jun 2016
Some comments I made on issue at PyCQA/flake8-bugbear#37 and reposting here to keep track of things:
We could always handle this internally in flake8-bandit. Definitely not a long term solution but a workaround until we can figure out which codes to be used by each project.
What are the thoughts around flake8-bandit changing the openstack/bandit code to be S30x for the time being? (quick look and it doesn't appear any other plugins are using S30x and S makes sense for "security")
Is anyone using flake8-bandit and comparing those results to the openstack/bandit cli output? That is the only time I could see this causing an issue as the codes won't match up
I've opened up an issue with openstack/bandit to see if we can pull them into the discussion here: https://bugs.launchpad.net/bandit/+bug/1759643
This have been closed. Please see the final discussion here:
PyCQA/flake8-bugbear#37