Popup with value
Opened this issue · 3 comments
Hi
I have integrated sematic's popup (no javascript version, available since 2.2). Would you like a PR, or is it not compatible enough?
I'm not quite sure what you mean when you say you have integrated semantic's popup. Does the range slider currently not work with a popup?
If you want to submit a PR I'd be glad to look at it.
It is easily possible to attach a popup to the whole slider, for me it is better to attach it to the moving dot (.thumb). It is possible to defined it outside and update in onChange:
$elem.find('.thumb').attr('data-tooltip', val);
But it is more elegant to include the popup directly inside the range.js.
My approach is very simplistic and only works with semantic 2.2+ when support for non-javascript popups was added. Btw javascript ones seems to be bugged when attached to .thumb, however I have not investigated much.
I hope I am clear enough this time.
@DamodarSojka feel free to make a pull request with your changes. If it breaks pre-2.2 versions I'll just publish your changes as a new release version and note the breaking change.