typed-ember/glint

[volar] implicit dependency on vscode-languageserver-protocol leads to server boot errors

Closed this issue · 1 comments

vscode-languageserver-protocol is used by the language-server here:

import * as vscode from 'vscode-languageserver-protocol';

but is not specified here:

"peerDependencies": {
"typescript": ">=5.4.0"
},
"dependencies": {
"@glimmer/syntax": "^0.84.3",
"@volar/kit": "2.4.0-alpha.16",
"@volar/language-core": "2.4.0-alpha.16",
"@volar/language-server": "2.4.0-alpha.16",
"@volar/language-service": "2.4.0-alpha.16",
"@volar/source-map": "2.4.0-alpha.16",
"@volar/test-utils": "2.4.0-alpha.16",
"@volar/typescript": "2.4.0-alpha.16",
"computeds": "^0.0.1",
"escape-string-regexp": "^4.0.0",
"semver": "^7.5.2",
"silent-error": "^1.1.1",
"uuid": "^8.3.2",
"volar-service-typescript": "volar-2.4",
"vscode-languageserver-textdocument": "^1.0.5",
"vscode-uri": "^3.0.8",
"yargs": "^17.5.1"
},

There may be other implicit deps but I didn't find them. I think the reason this has gone largely unnoticed is that

In 1.5.0 this is brought by vscode-languageserver which may be why this has gone unnoticed.

:shakes fist at cloud: YAAARRRRRNNNN