typed-typings/npm-bluebird

Promise.reflect() definition

Closed this issue · 9 comments

Was looking at latest definition file and didn't see that the .reflect method does not appear.

Is it possible that the .inspect method is a vestige from a previous version of the API?

It is ported from DT. So you are likely to be correct.

I'll be busy in the next three weeks so I don't have much time to work on things. Feel free to submit PR to fix it. :)

Taken care of. Will close this issue upon successful merge. For those who may have relied on .inspect method from v2.x.x of Bluebird (removed in 2014), see comments in the PR #10

Great. PR has been submitted here
#10

On Fri, Apr 22, 2016 at 12:10 AM, Homa Wong notifications@github.com
wrote:

It is ported from DT. So you are likely to be correct.

I'll be busy in the next three weeks so I don't have much time to work on
things. Feel free to submit PR to fix it. :)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9 (comment)

louy commented

I think .settle was also deprecated, right? I can't find it anywhere in the docs.

All set to merge. I'm not sure if the API is fully up to date, but I will
continue to submit further PRs as I find issues.

On Tue, Apr 26, 2016 at 5:04 AM, Louy Alakkad notifications@github.com
wrote:

I think .settle was also deprecated, right? I can't find it anywhere in
the docs.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9 (comment)

louy commented

Cool. Thank you @jacobdr!

Still need to submit the PR to the typings registry, right?

louy commented

I already did. typings/registry#357

Awesome. Sorry I didn't catch that.

JR

On May 2, 2016, 2:50 PM -0400, Louy Alakkadnotifications@github.com, wrote:

I already did.typings/registry#357(typings/registry#357)


You are receiving this because you were mentioned.
Reply to this email directly orview it on GitHub(#9 (comment))