typed-typings/npm-page

page.exit type is wrong

Closed this issue · 3 comments

The type for the function page.exit is

  function exit(path: string, callback: Callback, moreCallbacks?: Callback[]): void;

but it should be

  function exit(path: string, callback: Callback, ...moreCallbacks: Callback[]): void;

Thanks. Feel free to open a PR 🌷

Yes, I tried actually, as you can see I forked the repo but I'm not able to run the build and the tests, so I'm not sure how to proceed. I hope you can fix this

Got it. I take a look at it and the tool chain is pretty outdated.

Have made the change without tests.