Append .exe to Windows binaries

Question

Append .exe to Windows binaries

carymrobbins opened this issue 7 years ago · 3 comments

Psybur
When running gradlew compileEta Im getting this: > Failed to fetch file from url: http://88a2a1b21f8e03a6bc8d-8f2e61d843ea88e4f30ab3f81ca0e396.r42.cf5.rackcdn.com/etlas-1.0.2.0/binaries/x86_64-windows/etlas

Rahul Muttineni
That url should be http://88a2a1b21f8e03a6bc8d-8f2e61d843ea88e4f30ab3f81ca0e396.r42.cf5.rackcdn.com/etlas-1.0.2.0/binaries/x86_64-windows/etlas.exe

In the same way that we do a platform check in EtlasBinaryDependencyResolver#resolveRemote we need to append .exe to binary names in EtlasBinaryDependencyResolver#getEtlasUrlString.

Answer 1 · 2017-11-06T16:46:06.000Z

resolveInSystemPath() also needs to be modified. Perhaps others too, but can verify this one definitely needs it.

Answer 2 · 2017-11-15T06:09:11.000Z

@jrciii - I have a branch and PR out that should resolve this issue - 4-windows-binaries

If you can, try it out and let me know if this works for you. Otherwise we can review and merge.

Answer 3 · 2017-11-16T03:16:32.000Z

I'm going to go ahead and close this for now, @jrciii please reopen if you encounter any issues with this moving forward.