workaround needed for Scala 2.13.0-RC1
SethTisue opened this issue · 7 comments
see @adriaanm's changes at scalacommunitybuild@366f435
This is only a WIP that AFAICT will crash at runtime. Not sure yet how to fix this.
How is this code tested? spireJVM/test passes on RC1 directly from master without Adriaan's patch (using Machinist 0.6.7) and examples/test does something ("Generating spire/std/tuples.scala") that isn't obvious from the build description, but it doesn't contain any tests.
Try validateJVM.
validateJVM doesn't do much more. All test in there are passing. The sbt build isn't designed to deal with different dependencies for diffrerent target versions so it will require some refactoring for cross-building but other than that I see no issues with RC1.
Oh, looks like I somehow reset the Scala version again so I wasn't testing on RC1. And there's no version of algebra yet for RC1 (or any other 2.13 build), so I'll have to start with that.
Here's a fix for the sample code for completeness (not actually needed by this example): scalacommunitybuild@1037e5c
I gave up trying to run the test suite on a "proper" build of Spire using published versions of the dependencies outside of the community build because the changes in ScalaTest and/or scalacheck result in hundreds of compile errors.