typelevel/squants

Incorrect conversion factor in PowerRamp units per minute and per hour

Opened this issue · 1 comments

mzboray commented

Specifically the conversion between units such as WattsPerMinute and WattsPerHour are incorrect, see PowerRampSpec:

WattsPerHour(1) should be(WattsPerMinute(60))

This should be WattsPerHour(3600) should be(WattsPerMinute(60))

Also the types in PowerRamp use "m" for minutes in their symbols, but this is incorrect and "min" should be used. See Non-SI units mentioned in the SI.

charlietsai commented

Seeing the same issue.