Update variables/maintainability
Closed this issue · 5 comments
https://twitter.com/ldexterldesign/status/345230271890747392
Hey,
Simple $font-base-px for use with modular-scale() functions (e.g. http://bourbon.io/docs/#modular-scale )
I can't easilly update my copy of _typeplate.scss with new versions because the variables are scattered. It would be useful if all the variables were in one place (or even in a separate file)
I also see lots of hard coded rem values - so much for the modular scale, huh?:
Love your work :)
Yours hopefully,
Ok, so let's work down the list…
Simple $font-base-px for use with modular-scale() functions
Currently we output both rem and pixel values. We also have a modular scale calc that you can use as required per your project needs.
I can't easilly update my copy of _typeplate.scss with new versions because the variables are scattered. It would be useful if all the variables were in one place (or even in a separate file)
🤘 I totally agree → https://github.com/typeplate/typeplate.github.io/tree/development/typeplate/scss
I also see lots of hard coded rem values - so much for the modular scale, huh?:
No not at all. I'm working hard at making things better as we continue the project. Feel free to poke around the development branch. Everything is inside the “typeplate” directory. You would also be a good candidate for a beta tester so I highly suggest hopping over to the development branch before we release 1.1.0.
Oooh. That looks really awesome. Cheers. =)
Thanks @Melindrea. Feel free to test out our development branch that I've linked above. If you have any input feel free to file another issue.
@grayghostvisuals hey Dennis, cheers for feedback
Currently we output both rem and pixel values. We also have a modular scale calc that you can use as required per your project needs.
Good to know. Currently using http://bourbon.io/docs/#modular-scale 's modular-scale function, as it has double strand functionality ( thoughtbot/bourbon#175 ). I need a pixel value for it ;)
To my knowledge this is the most advanced modular-scale function around https://github.com/Team-Sass/modular-scale but you need http://compass-style.org/ (and I've stopped using that)
You may want to consider merging it in, as double strand (using two modular scales side by side) seems really useful for more granular control of measurements?
I totally agree → https://github.com/typeplate/typeplate.github.io/tree/development/typeplate/scss
Splendid work on https://github.com/typeplate/typeplate.github.io/blob/development/typeplate/scss/_vars-typeplate.scss - what's your release cycle like? Can I use this now?
Sure, I'll take a look at https://github.com/typeplate/typeplate.github.io/tree/development/ when I get an opportunity - love to contribute
Keep up the good work :1
Kind thanks,
Like I was saying you can try out the development branch and provide feedback. You're more than welcome to use this now as a beta tester as we have not announced it yet publicly so please keep it on the DL.
If you have an idea for a modular scale function over what we have currently please post that here before sending a PR. Thanks.