typeplate/typeplate.github.io

Responsive Lists ✭ That Wrap Like A Glove

Opened this issue · 6 comments

grayghostvisuals commented

Check this codepen from @TrentWalton
✭ http://codepen.io/TrentWalton/pen/skBnz

Basically the lists are being used like this...

ul li a {
    line-height: 2; // not a good approach
}

ul li a {
   line-height: 1.25; // a better approach
   padding: 0.375em 0; // padding used is the remaining amount from the computed line height / 2
}
jhogue commented

No one asked me, but adding padding to <a> as often as possible results in a larger touchable area, which is the best thing to do. So this is good practice in general, in my mind.

I know the intention here is to visually group any multi-line <li> elements, which is a very nice approach, so, sorry to get off topic a bit. Thumbs up.

grayghostvisuals commented

@jhogue If you'd like we can make you a core contrib and member for the project with pull access and eventually leading to both push and pull in the future?

jhogue commented

Hey, that'd be great. And an honor. If you trust me to do the right thing
(as I try to do) then grant away.

On Tue, Apr 9, 2013 at 2:47 PM, Dennis Gaebel notifications@github.comwrote:

@jhogue https://github.com/jhogue If you'd like we can make you a core
contrib and member for the project with pull access and eventually leading
to both push and pull in the future?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/89#issuecomment-16132177
.

J. Hogue: Design Director at Project Evolution
t: 888.456.0467 | c: 401.831.1963

grayghostvisuals commented

Ok you're in the cool kids club! \m/ As your contributing increases we'll update privs to full push and pull. 🙀

jhogue commented

Thanks man. I'll try and make y'all proud. You've got a great little thing
here, and I respect it. Thanks for the privileges.

On Tue, Apr 9, 2013 at 3:12 PM, Dennis Gaebel notifications@github.comwrote:

Ok you're in the cool kids club! \m/ As your contributing increases we'll
update privs to full push and pull. [image: 🙀]

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/89#issuecomment-16133735
.

J. Hogue: Design Director at Project Evolution
t: 888.456.0467 | c: 401.831.1963

grayghostvisuals commented

Absolutely! Lookin' forward to having you aboard for the ride. Let's make this thing "awesome-er" 🤘