Wrong return type in AtRules.php

Question

Wrong return type in AtRules.php

Closed this issue 3 years ago · 4 comments

I was trying to use the package on PHP 8.0 and got the following error message:

Deprecated: Return type of Typesetsh\Css\Grammar\AtRules::offsetSet($name, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in …/css/src/Grammar/AtRules.php on line 72

Deprecated: Return type of Typesetsh\Css\Grammar\AtRules::offsetUnset($name) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in …/css/src/Grammar/AtRules.php on line 80

Answer 1 · 2022-01-05T15:10:24.000Z

Thanks, will be fixed with the next minor typeset.sh release.

Answer 2 · 2022-01-05T18:23:39.000Z

Awesome. There were actually some more issues like this one, I’ve stumbled upon 10 or so.

Answer 3 · 2022-01-07T21:32:32.000Z

Okay 0.18.15 solves the offsetUnset() and offsetSet() issues - The offsetGet() : mixed return type will have to wait for release 0.19 where we will drop support for php7.2 and php7.3

Answer 4 · 2022-02-03T15:34:47.000Z

This is fixed on version 0.19