tzsk/collage

This lib uses the Laraval helper functions "with" and "collect"

chrfritsch opened this issue · 8 comments

Currently, this library can't be used outside of Laravel because it uses internal Laravel functions.

tzsk commented

@chrfritsch it can be, if you install it via composer. We have Unit-Tests to verify that.

I opened #71. I hope we get it merged because I would like to use this library in a drupal project.

tzsk commented

@chrfritsch can you not install it via composer? Or is that not an option?

I installed with composer. Laravel is only a dev dependency. So I don't get it. And I think it would be nice when I don't need the whole laravel framework to run this.

So this would really help me, that I don’t have to mess around with gd or Imagick

Would you also accept a PR for collage v4? Drupal still supports PHP7.3 so I can't use v5...

Ah, in v4 is a dependency on illuminate/support. So we don't need a patch. But nevertheless, I think it would be nice to get the PR for v5 merged.

tzsk commented

I removed framework dependency and added support. I kinda like Laravel helpers.