Show gray icon when not filtering
Closed this issue · 2 comments
When we access a site that's on the "no filtering" list, the uBOL icon remains red (clicking on it shows "filtering mode" as "no filtering"). It would be more intuitive to behave like uBO, with the icon turning gray when inactive.
Maybe it doesn't turn into Grey by intentional design, because some third-party requests might be still blocked and displayed on requests counter on a badge, even on a whitelisted site:
in that case on Firefox, where displaying requests counter on a badge is not possible, Grey could confusingly suggest that nothing is blocked, I'm not sure, if there is any color which could indicate that the site is whitelisted but still some 3rd-party requests might be blocked. Or just to go with Grey anyway.
This would require to wake up uBOL's service worker every time the URL in the address bar changes and every time a new tab is selected, while currently the service worker is not needed at all in basic mode, and only when cosmetic filtering is required in optimal/complete mode -- requirement which will go away once w3c/webextensions#403 is addressed -- thus losing the benefits of the entirely declarative approach.
Given this, I prefer to decline.
You could submit a feature request to browser vendors to support declaring a specific toolbar icon (maybe through setExtensionActionOptions) for when there is a allowAllRequests rule in effect in the top document in a tab.