uBlockOrigin/uBlock-issues

Add a flag image for Belgium + a better flag image for Nepal

Closed this issue · 2 comments

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

(De facto moving gorhill/uBlock#3910 to this issue report:)

Chromium browsers on Windows 10/11 currently have some minor issues with the Belgian and Nepali flags, where

image

As the main uBO repo already has a full set of Flags of the World images, adding [ '🇧🇪', 'be' ], to i18n.js would on paper fix the missing Belgian flag. Similar emote-to-imagename matches can be done for dozens of other flags just to be sure, though I apparently managed to botch many of the ones in my original PR.

For Nepal, replacing https://github.com/gorhill/uBlock/blob/master/src/img/flags-of-the-world/np.png with the below flag, should work pretty well:

np

Having thought about and kept an eye on the original PR for a while, I feel now that the best option for me is to move the report here, to allow better discussion and emote votes.

A specific URL where the issue occurs.

chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/dashboard.html#3p-filters.html

Steps to Reproduce

  1. Install a Chromium-based browser in Windows 11, e.g. Vivaldi or Chrome.
  2. Install uBlock Origin stable, which is 1.56.0 at the time of writing.
  3. Open uBO's settings' "Filterlists" page.
  4. See that there's minor oddities with the Belgian and Nepali flags in the EasyDutch and IndianList rows.

Expected behavior

That the Belgian flag shows up as an image in Windows+Chromium environments, and that the Nepali flag is properly transparent on uBO's grey background instead of being inside a white square.

Actual behavior

The 2 flags in question aren't optimally rendered.

uBO version

1.56.0

Browser name and version

Vivaldi 6.6.3271.50 x64

Operating System and version

Windows 11 23H2 x64, with all monthly 23H2 updates installed since

If you can submit a pull request with only the changes required to fix the issue here, I will merge it immediately.

Okay, sure thing. Give me 10min.