uBlockOrigin/uBlock-issues

marmiton.org trusted-scriptlet issue

Closed this issue · 5 comments

piquark6046 commented

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

The trusted scriptlet (marmiton.org##+js(trusted-click-element, #didomi-notice-agree-button)) does not work.
The similar filter exists in AdGuard Cookie popup filters list. However, AdGuard's one works as excepted.

AdguardTeam/AdguardFilters#175067

A specific URL where the issue occurs.

- https://www.marmiton.org/
- https://www.marmiton.org/recettes/recette_mousse-au-chocolat-tres-rapide_315805.aspx

Steps to Reproduce

  1. Add the above filter into My filters tab.
  2. Add user- into value of trustedListPrefixes key in uBO advanced settings.
  3. Visit the website.

Expected behavior

The cookie popup is hidden.

Actual behavior

The cookie popup is not hidden.

uBO version

1.56.0

Browser name and version

Chromium 122.0.6261.128 (Official Build) snap (64-bit)

Operating System and version

Ubuntu 23.10

gorhill commented

I could not reproduce, worked fine here:

image

piquark6046 commented

It seems that it was an internal issue in my uBO.
Closing the issue.

gorhill commented

Add the above filter into My filters tab.
Add user- into value of trustedListPrefixes key in uBO advanced settings.

Ok the issue is if adding user- after adding the filter. When modifying trustedListPrefixes, the lists are not re-compiled, we have to force a re-compile of whichever list is newly trusted.

This should be better with 1.57.0 since it's just a checkbox to trust My filters -- though the issue will still exist for other newly trusted lists. The reverse is also true, lists are not re-compiled when removing a token from trustedListPrefixes.

stephenhawk8054 commented

Would a Re-compile button next to Apply button in "Advanced settings" page be a good idea? Sometimes I indeed forget about that step too.

gorhill commented

Advanced settings is really made for very lightweight ways to change uBO's internal behavior for those who dare playing with them, and minding a recompile of affected lists is way outside the idea of keeping this simple. At most I see it as a quirk which should be documented.

  • 👍3