Unexpected `os_v3_replacement` in test

Question

Unexpected `os_v3_replacement` in test

Closed this issue 9 years ago · 3 comments

In regexes.yaml, line 905, the key os_v3_replacement causes an exception at line 99 of UaParser.cpp when running make test.

I'm not completely certain whether uap-core should change or uap-cpp, though I suspect uap-cpp of simply trailing uap-core.

Answer 1 · 2016-03-22T10:59:36.000Z

Based on the uap-python tests, I'm pretty sure the uap-cpp tests are just trailing the yaml file. I'll plan to swing back to this with a patch soon.

Answer 2 · 2016-03-22T22:15:36.000Z

@JeffAbrahamson A patch would be great, especially if you can keep it small. I plan to make this project work with the latest yaml file from upstream in a few days and merge the old pull requests as well, so we have to keep an eye on conflicts.

Answer 3 · 2016-03-28T03:52:29.000Z

@JeffAbrahamson Fixed, now it works with the upstream uap-core tests.