uatrend/pagekit

Do we really need uikit images ?

trk opened this issue · 3 comments

trk commented

Do we really need these app\system\modules\theme\image\*.* files ?

https://github.com/uikit/uikit/blob/develop/src/less/components/mixin.less#L11 We have a method here for inline svg usage.

Also we can use custom uikit icons js file for Pagekit CMS.

For these kind of usages #L98, #L102, #L105, #L108, #L111

## Example:

<span uk-icon="icon: pagekit-help; ratio: 2"></span> for #L98

Maybe, this icons the same, but they looks different. Default Pagekit icons more accurate. Maybe better would create own uikit-icons.js for pagekit? :)

trk commented

We can create a js file like pagekit.icons.js same content with uikit.icons.js, but we can add more custom svg icons after https://github.com/uikit/uikit/blob/develop/dist/js/uikit-icons.js#L156 line or all icons could be custom.

:) Hi guys! Pagekit icons in last commit (9340e92) now in 'uikit-icons.js' placed in /app/system/assets/js folder. Removed unused styles from less.