ubc/emoji-feedback

Look into flaky puppeteer tests

Closed this issue · 2 comments

Some of the UI tests that rely on network requests, i.e.

page.on('request', req => {
      expect(req.url()).toEqual('http://localhost:8080/form')
      expect(req.postData()).toEqual(JSON.stringify('hello'))
      expect(req.method()).toEqual('POST')
    })

can be flaky, especially when I'm testing the postData values of network calls made after the first call.

Did the best that I could to make it less flaky

But some of the ui tests are a bit hacky