Authentication Refactor Review
edjiang opened this issue · 0 comments
edjiang commented
In this latest batch of work, we move authentication code into the new UberCore module as well as refactoring the code to provide for some enhancements. This is to accomplish the following goals:
- Finish the modularization efforts begun in #193
- Improve the fallback experience to browser-based authentication. We now use
SFAuthenticationSessionandSFSafariViewControllerwhen appropriate instead of an embedded web view. End users that are already logged in on web will not need to sign in again on a 3rd party app. - Remove login views used in the old flows.
- Reduce boilerplate code needed to do authentication. See #201 to see the impact on a view controller.
More details are available in the specific PRs addressing the issues.
I've split this out into 8 different pull requests, all to be merged into separate-out-authentication-develop, which should result in the same code as the full separate-out-authentication branch. Independently, they will fail tests but the whole should pass. These should simplify the review of the changed code.