Unable to subclass RideRequestViewController
Closed this issue · 3 comments
codyrotwein commented
Can you change RideRequestViewController to open instead of public so that I can override/subclass it?
edjiang commented
Just curious, what are you trying to accomplish with the subclass? We may be making some changes in this area in the near future, so we don't want to accidentally break subclasses.
Otherwise, you might be able to get by for now by copy-pasting the RideRequestViewController into your code.
codyrotwein commented
Thanks for getting back to me Edward. I'm mainly subclassing it in order to
update the navigation bar buttons, as well as do some custom things related
to the menu controller I'm using in my app and some analytics type stuff.
I'd rather not have to copy-paste RideRequestViewController or modify the
Uber source. Please let me know if you guys have plans to change it to open.
Thanks,
Cody
…On Tue, Oct 10, 2017 at 8:13 PM, Edward Jiang ***@***.***> wrote:
Just curious, what are you trying to accomplish with the subclass? We may
be making some changes in this area in the near future, so we don't want to
accidentally break subclasses.
Otherwise, you might be able to get by for now by copy-pasting the
RideRequestViewController.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF27_rpt8QJqL4pAsE0OKkGipMN4DSafks5srAg8gaJpZM4PyohZ>
.
edjiang commented
Ride Request Widget was deprecated in 0.9, so I'm closing this as a non-issue anymore. Sorry!