ubleipzig/intermediateschema

AIAccessFacet is missing in schema

zazi opened this issue · 2 comments

zazi commented

Since it utilised in the span export processing, see https://github.com/miku/span/blob/a05d018c9174fd939cbbd9dacb36f80273ea04dd/formats/finc/solr.go#L171. Since AIAccessFacet is camel-cased, we should think about renaming it, or?

miku commented

Yes, the AIAccessFacet value is by default Electronic Resources. I would believe that this fixed value should be ok for the moment for most sources.

  • 👍1
zazi commented

from my current knowledge, this field does not belong to the intermediate schema (right now), it's simply a constant value that is defined in https://github.com/miku/span/blob/master/formats/finc/common.go#L33 and utilised in https://github.com/miku/span/blob/a05d018c9174fd939cbbd9dacb36f80273ea04dd/formats/finc/solr.go#L171