udacity/CarND-Extended-Kalman-Filter-Project

variable timestamp_ bits

jinchenglee opened this issue · 5 comments

jinchenglee commented

I noticed timestamp_ in GroundTruthPackage class uses long (32bits) but in MeasurementPackage it uses long long (64 bits). Shouldn't we use same number of bits in both places? And it seems 32 bits cannot hold all widths of time stamps.

It probably won't report out error as we care only about delta in time stamps, but it will incur truncation by long(32bits) I believe.

sookinoby commented

@jinchenglee This causes a bug in windows mingw. I had hard time figuring out what was wrong. Did you create a pull request?

jinchenglee commented
jwdunn1 commented

The declaration of previous_timestamp_ in FusionEKF.h should be also be long long. (I lost time tracking that one down.)

dyh1213 commented

Come on ... this issue just cost me a week of frustration.

andrewpaster commented

Hi, I updated the repo with the long long declarations. @jinchenglee I don't see a pull request for this, did you close it at some point?