udacity/cloudflare-typescript-workers

Consider switching from to edge-mock

Closed this issue · 2 comments

samuelcolvin commented

Hi, you might consider switching from service-worker-mock to edge-mock (which I've just built).

Just a suggestion, feel free to close this if you like.

A few advantages of edge-mock:

  1. service-workers the project which service-worker-mock is a part of is no longer maintained.
  2. edge-mock provides support for KV store mocking out-of-the-box
  3. edge-mock properly supports ArrayBuffer and ReadableStream which service-worker-mock do does not
  4. edge-mock has close to 100% test coverage and is written in typescript.
  5. All the implementations provided by edge-mock are fully compliant with the types they implement in typescript.
13rac1 commented

Hi! edge-mock has a hardcoded dependency on @cloudflare/workers-types which regretably duplicates the types in this project. Please see #19 I'd prefer to sunset/handoff this project entirely.

samuelcolvin commented

Makes sense, thanks

  • ❤️1