udacity/reactnd-project-myreads-starter

Do we really need to ignore yarn.lock?

barabadzhi opened this issue · 3 comments

barabadzhi commented

Hi, guys!

Here we are ignorring the yarn.lock file:

reactnd-project-myreads-starter/.gitignore

Line 2 in 29ba2f0

yarn.lock

But this is a misuse of this file according the documentation:

... consistent installs across machines ...
... To do this Yarn uses a yarn.lock ...
Yarn Docs

This is good to have .lock files checked-in for consistency and speed.

PS: Thanks for the course, its awesome. 🙂

khw1031 commented

hmm. It is kind of weird. .gitignore shouldn't exclude yarn.lock file. 😃

fpigeonjr commented

👍 right the .gitignore from create-react-app includes:

.idea/
.vscode/
node_modules/
build
.DS_Store
*.tgz
my-app*
template/src/__tests__/__snapshots__/
lerna-debug.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
/.changelog

no mention of the yarn.lock

veronikabenkeser commented

Thank you for flagging! Fixed.