Screen junk with latest update

Question

Screen junk with latest update

StanleyKnife opened this issue 4 years ago · 17 comments

Describe the bug
When Polyglot is loaded, a pages with Arabic text shows an always-on grey box. Text highlighted for translation shows a spinning box top left.

Screenshots

Always-on box at top, highlighted translation bottom.

Version (please complete the following information):

Version 3.2

Answer 1 · 2021-01-20T23:23:30.000Z

I'm not able to reproduce

using https://ar.wikipedia.org/wiki/بدر_البوسعيدي as a test

Answer 2 · 2021-01-21T09:14:39.000Z

Sorry - the site is fm.gov.om and I'm finding this issue each time I turn Polyglot back on. My co-workers are finding the same issue.

Answer 3 · 2021-01-21T09:19:24.000Z

OK this is really odd. I've found that when I translated some text while editing the page (and thanks for that new ability, by the way) the following code was inserted in the panel I was editing:

Answer 4 · 2021-01-21T10:35:02.000Z

that's the problem!

What type of edit control is the page using?

Answer 5 · 2021-01-21T10:45:16.000Z

It's the Avada theme, which has its own editing environment.

Previously Polyglot was unable to translate Arabic text within the editor window, so it wasn't an issue. I think I should just remember not to use it here.

By the way, Polyglot is a fantastic tool. Exactly what I need. Thank you!

Answer 6 · 2021-02-12T10:00:47.000Z

I have also had Polyglot leaving text inside of text fields after selecting text in text field. I was editing an item on archive.org at the time.

Answer 7 · 2021-02-12T18:58:59.000Z

Yes, it seems to happen when you translate text inside an edit field. Works fine on non-editing web pages.

…

On 12 Feb 2021, at 10:01, Matt Sephton ***@***.***> wrote: I have also had Polyglot leaving text inside of text fields after selecting text in text field. I was editing an item on archive.org at the time. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYV46QEHKPZ7N2P7ATM3STS6T355ANCNFSM4WK2VD4Q>.

Answer 8 · 2021-02-13T13:37:28.000Z

I thought that in #28 translation was disabled in text field? @uetchy

because it's most likely the words in there are either in your own language, or words I am typing myself!

Answer 9 · 2021-02-13T14:22:40.000Z

No, you can still translate - but the extra code is inserted when you do.

…

On 13 Feb 2021, at 13:37, Matt Sephton ***@***.***> wrote: I thought that in #28 <#28> translation was disabled in text field? @uetchy <https://github.com/uetchy> because it's most likely the words in there are either in your own language, or words I am typing myself! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYV46WDTUNV7JLPXN3K76DS6Z6CTANCNFSM4WK2VD4Q>.

Answer 10 · 2021-03-18T00:54:07.000Z

I am getting this in every text area:

Wordpress
Wikipedia
Internet Archive

It's very disruptive because I have to check and delete the stray html

Answer 11 · 2021-03-18T04:54:55.000Z

Actually I couldn't reproduce this bug. Could you give me a complete and precise procedure to reproduce the bug?

Answer 12 · 2021-03-18T10:26:35.000Z

Sure!

it is too easy to lose control of the popup and for its HTML to be saved with the contents of the text area.

Screen recording:

https://imgur.com/a/S5p8gzn

Setup:

goto https://archive.org/create/
click: Upload Files
select a local file to upload (we're not actually going to upload it)
click: description field
type some description
select the text you have just typed

Problems:

spinner never goes away
multiple popups
top left popup is not under your direct control

Next, without dismissing the popup:

click into another field, eg. Subject tags
click back into Description field
choose <> button (html code view)

Problem:

the code for the popup remains in the text field
clicking on the text field will remove the old popup code

Answer 13 · 2021-03-18T10:45:20.000Z

Similarly, with WordPress:

I do not have time to show Wikipedia, but the process is the same.

Basically

do something on the page to change DOM before popup is dismissed and we lose control of the popup and its HTML code
popup HTML should not be added to text area

Answer 14 · 2021-03-19T08:46:27.000Z

I can confirm.
That's a bit tricky problem.
Normally Polyglot can suppress instant translation when the selected text is in a textarea or input tag, but in this case the editor is just a body inside iframe that Polyglot cannot tell it's an editable text.

Answer 15 · 2021-03-19T08:49:06.000Z

Disabling handling iframe is the easiest route, but I don't want to do it because it also prevents me from translating live chat comments on YouTube. We need to find another solution to this.

Answer 16 · 2021-03-19T11:18:27.000Z

I'll also think about this problem.

Answer 17 · 2021-03-19T11:59:54.000Z

Just to make some notes on possible exclusion list of selectors:

Internet Archive: div.wysiwyg iframe
WordPress: div.mce-tinymce
Wikipedia: div.ve-ce-surface

An option to disable in iframe could be possible? Or only disable iframe on certain sites? This would only fix Internet Archive.

Could the popup be created at top level of DOM? Immediately after body tag, and then positioned absolutely? Just thinking out loud.