ufrisk/MemProcFS

`VmmProcess` should implement `Copy`

zacryol opened this issue · 2 comments

#[derive(Debug)]
pub struct VmmProcess<'a> {
pub vmm : &'a Vmm<'a>,
pub pid : u32,
}

All of this struct's fields are pub and implement Copy, so there's no real reason to not make it Copy + Clone (or at the very least Clone).

The lack of these traits doesn't even prevent the user from "copying" it manually, since all fields are pub.

Thanks for the suggestion.

I've added Clone (and Copy to some degree) to a bunch of different structs in 5.11.7.

Let me know if this will do and if the changes are fine.

I'm closing this issue. Since I haven't heard anything about it, I'll assume things are fine.