`VmmProcess` should implement `Copy`
zacryol opened this issue · 2 comments
zacryol commented
MemProcFS/vmmrust/memprocfs/src/lib_memprocfs.rs
Lines 1611 to 1615 in 98dd0d4
All of this struct's fields are pub
and implement Copy
, so there's no real reason to not make it Copy + Clone
(or at the very least Clone
).
The lack of these traits doesn't even prevent the user from "copying" it manually, since all fields are pub
.
ufrisk commented
Thanks for the suggestion.
I've added Clone (and Copy to some degree) to a bunch of different structs in 5.11.7.
Let me know if this will do and if the changes are fine.
ufrisk commented
I'm closing this issue. Since I haven't heard anything about it, I'll assume things are fine.