support light terminal theme

Question

Closed this issue 6 months ago · 6 comments

Related to #224 because the core issue was not solved.

REPL and console output is unreadable on bright terminal themes, due to hardcoded pastel colors.

Let's take a look at my terminal:

Code printed by the REPL is not legible.

I see two solutions to this problem:

Use 16 standard ANSI colors according to their names and assume the user configure terminal to make colors legible in both dark and light mode.
Use 24 bit color. Allow the users to configure color theme by specifying token type - color mappings (example: Constant = #ff0000). This can be achieved via configuration file, xresources, env variable (like LS_COLORS) etc. This method should also assume the user can change theme at any time. Perhaps \e]11;?\a escape code could be used to determine what theme to use?

#224 --no-color flag is only partial solution because I want colors while using light theme 😄

This problem does not affect the pad, code is legible in both light and dark theme.

Answer 1 · 2024-03-22T03:07:37.000Z

I have switched to ANSI colors for everything except number literals, which in my testing seem legible with the orange color in light or dark mode.

Answer 2 · 2024-03-22T03:09:11.000Z

Sorry, I forgot about the colored output

Answer 3 · 2024-03-22T03:11:17.000Z

Weird, the output colors look fine for me in both light and dark mode.

Answer 4 · 2024-03-22T11:19:29.000Z

I compiled main right now and it fixes the code colors 👍️

Literals are not readable. Tested on wezterm, alacritty and contour.

This is how ansi --color-codes output looks like for me:

Answer 5 · 2024-04-13T22:01:28.000Z

This may be fixed in 9796237.
While I see no difference in my environment, please let me know the results on yours.

Answer 6 · 2024-04-14T12:28:18.000Z

Colors are quite subtle, but it fixes the issue. Thanks!