uloco/theme-bluloco-dark

Jupyter notebook cell border not visible

echomehran opened this issue ยท 42 comments

I use the theme and I think the color harmony is very good but in jupyter notebook extension cells are not bordered or focused and it makes my eyes tired in long-term work I've tweaked the workbench.colorCustomizations but it didn't work

uloco commented

Could you please provide an example notebook file and maybe a screenshot? I already looked into notebooks and fixed everything I noticed, but some parts weren't implemented yet. Also don't use them myself, so not sure exactly what you mean.

Screenshot 2021-04-04 134637

I mean the part between input and output I want to have them separated by different colors or border like this one

2

the white edition is like what I want; I think the problem is with color

Screenshot 2021-04-09 141155

uloco commented

Thanks for clearing this up, will look into it when I got time this week.

uloco commented

Do you have the latest version of the theme? Because when I try to replicate I got this:

image

Also make sure you use the latest vscode version please.

uloco commented

Maybe this ticket is also helpful: microsoft/vscode-jupyter#580

Do you have the latest version of the theme? Because when I try to replicate I got this:

image

Also make sure you use the latest vscode version please.

I have the latest version of both of them
vscode is the latest version >>>1.55.2
And my theme version is v3.3.4

Also in other themes that I've sent above it's ok

Maybe this ticket is also helpful: microsoft/vscode-jupyter#580

I think it doesn't have to do with my problem because in this case if I'm not mistaken I should use the insider version of vscode but I use the stable version. In addition, the white edition of your theme is ok as I mentioned above

uloco commented

I am also using the stable version and seeing a different UI (the new one). Your screenshots show an old UI. I did update the theme according to the new colors, so it might be different for light and dark of course.

I cannot reproduce the issue on my side because the UI is different. The ticket above describes an issue with the jupyter notebook UI not updating (since vscode changed it a few updates ago), which was in insiders back then but is now default in stable. Maybe you have a setting to use the old UI in your user settings?

uloco commented

Are you using the deprecated jupyter extension maybe?
image

Are you using the deprecated jupyter extension maybe?
image

No, I'm using the first one

uloco commented

Oh I think now I understand what the problem is. It's in interactive mode. Will look into it!

Oh I think now I understand what the problem is. It's in interactive mode. Will look into it!

I don't think so, take a look at this it's the interactive mode

Screenshot 2021-04-20 180335

uloco commented

Have you overwritten some styles in your settings.json? I seriously cannot understand what is going on

Are you using the deprecated jupyter extension maybe?
image

No, I'm using the first one

Screenshot 2021-04-20 180039

Have you overwritten some styles in your settings.json? I seriously cannot understand what is going on

Yes I have let me show you the pic

uloco commented

I think that info is just outdated

I think that info is just outdated

maybe, I don't know

You mean this, Am I right?
Screenshot 2021-04-20 180755

uloco commented

yes that is why you are seeing the old ui

uloco commented

remove and restart your editor please

remove and restart your editor please

what do you mean, Uninstall the vscode ?

uloco commented

remove that line from your settings.json and restart your editor completely

remove that line from your settings.json and restart your editor completely

I just added that according to the info of the extension but I removed it as you said and nothing has changed

I removed it, nothing has changed

uloco commented

Did you override some workbench color customizations in your settings?

Did you override some workbench color customizations in your settings?

Yes I did, but it was after installing your theme and also it's related to the terminal

let me double check

uloco commented

Hmm. I really don't know why you are seeing the old UI. I cannot reproduce this whatever I do. Sorry...

Hmm. I really don't know why you are seeing the old UI. I cannot reproduce this whatever I do. Sorry...

Whatever man thank you so much
I've tried lots of popular themes but yours is really great and it suits my needs

uloco commented

Thanks, no problem :). But I still really think it is the old UI you are using somehow. Maybe you could try making a clean install of vscode.

Yes, I think you're right the problem is with the UI, I have to figure out how to install the new one

uloco commented

The terminal changes could also affect the output. maybe they used the output terminal color for this in the old ui.

let me remove them

But why the white edition has no problem?

I just commented those out but still the same result

How can I install the new UI?

Can you just tweak the color customization to make it work?

uloco commented

i think the white edition is just using a different color that might be the same for the dark theme. I just cannot find out which one is used for the old ui. I don't know how to make the new UI work. I think it is some caching issue. I would remove vscode completely, remove also caches and installed extensions and try again. (maybe also try with insiders if you have the same issue there.)

It's OK on the insiders version :) but is there any way to make the stable version behave like this?
insiders

uloco commented

You could try using settings sync to backup your settings etc and remove vscode completely, clear any caches on your system and then reinstall

uloco commented

I'm closing this, since it isn't an issue of the theme itself. You can still write here and keep me updated when you have found a way to fix your editor issues. Cheers!