uluyol/heyp-agents

Invalid frac_lopri crashes cluster-agent

Closed this issue · 0 comments

Seen today

cluster-agent: heyp/cluster-agent/allocator.cc:361: auto heyp::(anonymous namespace)::DowngradeAllocator::AllocAgg(absl::Time, const proto::AggInfo &, proto::DebugAllocRecord::DebugState *)::(anonymous class)::operator()() const: Assertion `false && "frac_lopri >= 0"' failed.

frac_lopri is likely a NaN since I can't think of a reason it would end up < 0. Instead of treating this a fatal error, we should issue a warning and clamp the value into [0, 1].