uui-swatch: checkmark has too low contrast on light colors
bjarnef opened this issue · 3 comments
Which exact UI Library version are you using? For example: 1.0.1 - don't just write v1.
1.6.0-rc
Bug summary
It seems #649 changed the uui-swatch so checkmark doesn't has sufficient contrast on light background colors, e.g. on yellow background the checkmark used to be black: https://uui.umbraco.com/?path=/story/uui-color-swatches--overview
That's why it had the isLight() function and set the color-swatch--light CSS class.
Specifics
No response
Steps to reproduce
Select light colors in uui-swatches or uui-swatch and notice checkmark is always white.
Expected result / actual result
No response
@bjarnef I believe this issue can be closed.
While it has changes for yellow, it seems to have low contrast for other colors.
which should show this instead:
@bjarnef what page of the UUI site are you using for your screenshot?
Brown looks good:
There are some questionable ones, for example:
Perhaps overlaying a check isn't the right, or "most accessible" solution anyways.