Custom properties naming
Opened this issue · 2 comments
vitaliy-bobrov commented
Now custom properties names look like this - --extra-confettiLengthVariance
, which is a mix of 2 styles - camelCase and CSS one, IMHO it might be better to use names more common for CSS, ex. --extra-confetti-length-variance
instead
nucliweb commented
I agree with @vitaliy-bobrov
The Material Design Theming Guide has custom properties with naming --mdc-theme-primary
, can you see Step 4: Changing the theme with CSS Custom Properties at https://material.io/develop/web/docs/theming/
And the same CSS custom properties naming in Firefox 👉🏼 https://github.com/mozilla/gecko-dev/blob/4ff64f4001ea521adba31bbe8fd5fa547c99e0b2/browser/themes/osx/browser.css
nucliweb commented
I can help with the refactor too 😊