undark-lab/swyft

Add support for pytorch-lightning 2.0.0

cweniger opened this issue · 3 comments

Currently Swyft crashes with PL 2.0.0. Swyft should be updated without breaking backward compatibility with PL 1.9.0 and earlier.

Even after the above merge there are issues when running "infer" with lightning 2.0.0, because of some incomplete limitations of the CombinedLoader in 2.0.0. This probably will solve itself over time as 2.x.x becomes more stable. For now the recommendation will be to stick to 1.9.x.

Recent discussions in pl here:

But it still looks like it will not solve all problems (predict loop is not touched).

Solution strategy: Write custom CombinedLoader within swyft. Might also be useful for #133