unexpectedjs/unexpected

[website] Maintain secure HTTP when clicking links

plroebuck opened this issue · 3 comments

plroebuck commented

If site was navigated to securely, then intrasite links should use of 'https' protocol.

Steps to Reproduce

  1. Securely navigate to Assertions https://unexpected.js.org/assertions/any/to-be/.
  2. Click on any link in (left side) list (e.g., number/to-be-close-to)
  3. Page reverts to unsecured navigation!

Fix

Two choices:

  1. Use schemeless URLs (e.g., href="//unexpected.js.org/assertions/number/to-be-close-to")
  2. Use only secure URLs (e.g., href="https://unexpected.js.org/assertions/number/to-be-close-to")

Note

The steps to reproduce is for example. This issue is site-wide and affects other pages as well.

sunesimonsen commented

Great - I didn't know that js.org started supporting https. I think we should just move to that.

sunesimonsen commented

Most of these changes will need to happen in https://github.com/unexpectedjs/unexpected-documentation-site-generator which unfortunately is a bit hacky :-)

papandreou commented

All links are relative now, so this is no longer reproducible. Thanks for reporting!