unfold/react-firebase

Rename `connect` HoC

Closed this issue · 4 comments

simenbrekken commented

While the name is generic it might collide with redux and for people coming from redux it might be confusing. In @unfold/fetch-data we're more wisely IMHO using the name connectFetchData

simenbrekken commented

@einarlove How about withFirebase or something similar in the spirit of Recompose and Apollo?

einarlove commented

Well withRouter or withTheme Takes no arguments and passes one prop from context. So withFirebase confuses me.

einarlove commented

I'm 👍 for connectFirebase, but would wait with it since it's a breaking change

einarlove commented

Unless

export connect from './conmectFirebase'
export connectFirebase from './conmectFirebase'
  • 👍1