unicodeveloper/laravel-password

Is the flip needed?

jkudish opened this issue · 2 comments

Hey there,

Thanks for this package, it's great :)

I'm just wondering, why do you need to flip the array of dumb passwords? No scientific measures here, but this operation seems to be kind of memory intensive and take a bit of time to run. It is causing some of my tests in a project to fail due to running out of memory.

If I remove it, everything still seems to work as expected, and run a bit faster and use less memory.

Let me know. I'd be happy to submit a PR to remove it.

Thanks! 😄

Also, perhaps the array could be cached?

@jkudish Thanks. I needed to flip the array to make the keys the values & the values the keys. Feel free to submit a PR.

I'll be waiting for the PR 👍