ModelEncoder always hits an instance, fail if not?

Question

Closed this issue a year ago · 2 comments

Whenever we call history/DjangoJSONModelEncoder we hit an instance. However, we still cater to the idea that we may not. This leads to problematic testing. Should we fail instead?
https://github.com/terjekv/mreg/blob/7c575e6d572723009b9c9f9f26dc4a8da3ed9ecf/mreg/api/v1/history.py#L18

Answer 1 · 2023-03-27T05:28:00.000Z

This code path is removed via 014e25b in #484.

Answer 2 · 2023-05-25T09:39:10.000Z

And re-fixed in #496 and logged in #500.