Add app-pack-gen build to Unity py
Closed this issue · 16 comments
add to the "application" services within unity py the abilty to request an application build.
The required inputs (currently) for app-pack-gen calls are the repository to be built. The url of the build needs to be figured out with @edwinsarkissian and @mcduffie but currently i think its:
/ads/mcp-clone
and requires the auth header, json content type, and the 'clone_url' header to execute correctly.
Example of the clone_url value is https://github.com/unity-sds/unity-example-application
Some questions:
- long-term, this will point to the app catalog (Dockstore) to get the repo name/tag/version, correct?
- do we expect near-term that applications will be at the top-level of the unity-sds organization?
Some questions:
- long-term, this will point to the app catalog (Dockstore) to get the repo name/tag/version, correct?
- do we expect near-term that applications will be at the top-level of the unity-sds organization?
What do you mean "top level" unity-sds org? in Github? the code can be anywhere in github- outside our org would be preferable.
By top level I mean:
https://github.com/unity-sds/unity-example-application
(the application is at the same "level" in github as, say, a unity-data-services or unity-sps)
vs.
https://github.com/unity-sds/apps/unity-example-application
(some place to put "applications" within the unity-sds organization)
(where is there a "catalog" of these?)
(also... I am getting confused... these applications are the "algorithms"... app packages that run in SPS, right? These are not the management-console "applications")
@mike-gangl @anilnatha who will actually do this work with unity-py?
Is it something that James' team should work on? Is it important to knock this out during this sprint (vs other priorities)
This would essentially be a wrapper around a REST call. See: https://docs.google.com/document/d/15oT2unTgZkhaXIVTva3BNZAA9O5etRsf/edit ~ page 18.
@rtapella ping for status.
likely to push out. the health-status feature of unity.py is higher priority
This could be a bigger deal than just wrapping a RESTful endpoint. need to look into it more.
It does make sense to be in unity.py though
blah = new Application()
application.register("some parameter / url?")
@mcduffie we only need the Cognito token for authentication, correct? (not github etc.)
Then we just need to pass in the code repo URL as the argument, right? Do we need to pass in a branch name?
And it places the App Package in Dockstore, right?
What's returned by the API? The Dockstore URL? CWL URL?
Yes you only need Cognito authorization. It doesn't return anything useful yet.
Likely to push this out a sprint
This is high priority for the start of sprint 24.3.2
this is done and merged into monorepo
it is part of unity-sds-client 0.6.0