universal-ctags/citre

FAILED test-global-get-references

masatake opened this issue · 5 comments

When I did 'make' just after doing git pull, I got:

[test] tests/global-backend
Running 1 tests (2021-10-11 03:35:36+0900, selector ‘t’)
Test test-global-get-references backtrace:
  call-process("gtags" nil "*gtags*" nil "--compact" "--file=src.list"
  (eq (call-process (or citre-gtags-program "gtags") nil "*gtags*" nil
  (if (eq (call-process (or citre-gtags-program "gtags") nil "*gtags*"
  (progn (setenv "GTAGSCONF" nil) (setenv "GTAGSLABEL" nil) (setenv "G
  (unwind-protect (progn (setenv "GTAGSCONF" nil) (setenv "GTAGSLABEL"
  (let ((process-environment-orig process-environment)) (unwind-protec
  (lambda nil (let ((process-environment-orig process-environment)) (u
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name test-global-get-references :documenta
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test 
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-l" "ert" "-l" "/home/yamato/var/citre/citre-common
  command-line()
  normal-top-level()
Test test-global-get-references condition:
    (file-missing "Searching for program" "No such file or directory" "gtags")
   FAILED  1/1  test-global-get-references (0.000340 sec)

Ran 1 tests, 0 results as expected, 1 unexpected (2021-10-11 03:35:36+0900, 0.097797 sec)

1 unexpected results:
   FAILED  test-global-get-references

[test] A test in tests/global-backend failed.
make: *** [Makefile:11: test] Error 1

Is this expected behavior?

I think it's because this?

(file-missing "Searching for program" "No such file or directory" "gtags")

Oh, I see. Thank you.

When gtags or global can't be found, I think we should make it show a warning and continue other tests, so developers who don't care about the global plugin don't have to install global.

When gtags or global can't be found, I think we should make it show a warning and continue other tests, so developers who don't care about the global plugin don't have to install global.

This is what I expected as the default behavior.

b9b76a3 closes this:

The tests are rearranged, and the Makefile target "test-common" tests the common library, and "test-tags", "test-global" test the backends. When testing the backends, the script checks if their dependencies exist. If not, it shows a warning and skip the tests