Switch from using AES CFB to AES GCM

aaronjwood opened this issue 8 years ago · 1 comments

aaronjwood commented 8 years ago

I'd like to propose that this library use AES in GCM mode instead of CFB mode https://github.com/Unknwon/com/blob/28b053d5a2923b87ce8c5a08f3af779894a72758/string.go#L45 https://github.com/Unknwon/com/blob/28b053d5a2923b87ce8c5a08f3af779894a72758/string.go#L61

GCM is fast (can be parallelized) but is also authenticated which is the biggest benefit over CFB and most other modes.

unknwon commented 8 years ago

Thanks, if possible, please propose a PR 😄

👍1